<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100293/">http://git.reviewboard.kde.org/r/100293/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100293/diff/1/?file=6047#file6047line181" style="color: black; font-weight: bold; text-decoration: underline;">src/add-account-assistant.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void AddAccountAssistant::accept()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">181</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// Don't try and add empty parameters or ones where the default value is still set.</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is actually very important, so it needs to be reinstated. The reason for this is that if I don't set a value on a parameter, I want it to keep it's default value, and that means, if in a new version of e.g. gabble the default value changes, I want the new default value to happen.
So, any unmodified parameters should not have their values recorded to the AM, but only defaults should be used.
This was discussed with upstream (Telepathy) at the time I implemented this originally, and was considered to be very important.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I haven't done a full review, but this item caught my eye from your summary of changes.</pre>
<p>- George</p>
<br />
<p>On January 3rd, 2011, 8:17 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated 2011-01-03 20:17:01</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Compile against Telepathy-Qt4 0.5
Changed account abstract-account-parameters-widget.h to return
QVariantMap of parameterValues() instead of trying to
QMap<ParameterItem,QString> which didn't compile.
There didn't appear to be a reason for doing this as it was just copied
to a QVariantMap directly after anyway.
Note that the code now doesn't remove any parameters which have the same
value as the default. This didn't seem to be a step required by
Telepathy.
Also updated parameter-edit-model to always return the value in the type
requested by the ProtocolParameter.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checked it now compiled
Added an account, edited an account and removed an account. Account adding and editing done using both the UI plugins and the generic configuration.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/abstract-account-parameters-widget.h <span style="color: grey">(6357b4eaff3b5579b44d9040ffe33314bbf09d80)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.h <span style="color: grey">(4c78338603dc0b88230b52190ca9d373dff2628d)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.cpp <span style="color: grey">(b554db71a17a4c9664d04f781561ce62cbc17562)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.h <span style="color: grey">(0c762ea5a30253cd1c4b772f3859b681f4fa8dd4)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.cpp <span style="color: grey">(0fe52a10798b03dff5491d78c1b16ad72e2f0533)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-widget.h <span style="color: grey">(4d3b5a62735bd519ce01f39037dad151e6b34cb3)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-widget.cpp <span style="color: grey">(187c39fbf990b610b8985d1869d48bc2be7c9c6d)</span></li>
<li>src/KCMTelepathyAccounts/parameter-item.h <span style="color: grey">(14b11160204a5b76ee3b0fed65861d0ceec87a7f)</span></li>
<li>src/KCMTelepathyAccounts/parameter-item.cpp <span style="color: grey">(318f175ec60b0dc31edadb72eda769b791ff9827)</span></li>
<li>src/KCMTelepathyAccounts/protocol-item.cpp <span style="color: grey">(03ac0bceff0f32673a706329f698a66323842c69)</span></li>
<li>src/account-item.cpp <span style="color: grey">(50afaa54c96ad51b6775f954cc180d1e12bbe96b)</span></li>
<li>src/add-account-assistant.cpp <span style="color: grey">(3933763957b1448aacf9e6c7efbc6b296a5e3664)</span></li>
<li>src/edit-account-dialog.cpp <span style="color: grey">(73462f2e2a93e22e6d5d67297c575f4e10d44c5c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100293/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>