<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5483/">http://svn.reviewboard.kde.org/r/5483/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 29th, 2010, 8:58 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5483/diff/1/?file=38708#file38708line49" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/playground/network/telepathy-chat-handler/lib/chatstyleplistfilereader.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span class="o"><</span><span class="n">QString</span><span class="p">,</span> <span class="n">QVariant</span><span class="o">></span> <span class="n">data</span><span class="p">;</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span class="o"><</span><span class="n">QString</span><span class="p">,</span> <span class="n">QVariant</span><span class="o">></span> <span class="n">data</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This does not conform to KDE coding libs standard (read about "d pointers").
I'm trying to move all the chatwindow/lib code to follow this. Though it's ongoing at present.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did not think about this, but sounds reasonable.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 29th, 2010, 8:58 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5483/diff/1/?file=38709#file38709line30" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/playground/network/telepathy-chat-handler/lib/chatstyleplistfilereader.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">read</span>File</span><span class="p">(</span><span class="n">fileName</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">Q</span>File</span><span class="hl"> </span><span class="n"><span class="hl">bla</span></span><span class="p">(</span><span class="n">fileName</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is "bla" a good name for this variable?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops :-D
Was just testing something ... </pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 29th, 2010, 8:58 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5483/diff/1/?file=38709#file38709line32" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/playground/network/telepathy-chat-handler/lib/chatstyleplistfilereader.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">readAndParseFile</span><span class="p">(</span><span class="n">bla</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should you be checking the return value of this?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually yes. But atm it always returns 0. Should fix both though.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 29th, 2010, 8:58 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5483/diff/1/?file=38709#file38709line49" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/playground/network/telepathy-chat-handler/lib/chatstyleplistfilereader.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span><span class="hl"> </span><span class="mi"><span class="hl">1</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't use "magic numbers" always define an enum where possible.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ack.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 29th, 2010, 8:58 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5483/diff/1/?file=38710#file38710line216" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/playground/network/telepathy-chat-handler/lib/chatwindowstylemanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QMap<QString, QString> ChatWindowStyleManager::getAvailableStyles() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">213</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">// // Ignore this MacOS X "garbage" directory in zip.</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">216</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">currentDir</span><span class="o">-></span><span class="n">entry</span><span class="p">(</span><span class="n">QString</span><span class="o">::</span><span class="n">fromUtf8</span><span class="p">(</span><span class="s">"Contents/Resources/Outgoing/Content.html"</span><span class="p">)))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This file doesn't actually need to exist. See Adium spec.
also I would personally prefer:
bool validResult = true;
if (! currentDir...)
{
validResult = false;
}
if (! currentDir...)
{
validResult = false
etc.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just reenabled the old Kopete code. Probably it's even wrong sometimes (as soon as more than one theme is in a bundle).
I wouldn't like to change that now because the chatstylemanager needs some refactoring anyways.</pre>
<br />
<p>- Dominik</p>
<br />
<p>On September 29th, 2010, 8:41 p.m., Dominik Schmidt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for telepathy and Gustavo Boiko.</div>
<div>By Dominik Schmidt.</div>
<p style="color: grey;"><i>Updated 2010-09-29 20:41:05</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The main.cpp is a little hacky.
Should I subclass KApplication and put the install function there?
This would avoid the global app pointer and I could then add a slot displaySuccess() or something which would then show a knotification.
Other suggestions how to solve this?
If you want to test it, just go to http://www.adiumxtras.com and click an install link for chat styles or emoticons. It's broken in KDE (at least) trunk though :-(
You can test it simply this way:
adiumxtra-protocol-handler adiumxtra://www.adiumxtras.com/download/2463 (for Gone Dark theme)
adiumxtra-protocol-handler adiumxtra://www.adiumxtras.com/download/4058 (for cool_cat emoticon theme)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, works for me :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/playground/network/telepathy-chat-handler/lib/chatwindowstylemanager.cpp <span style="color: grey">(1180207)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/emoticonsetinstaller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/emoticonsetinstaller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/lib/chatstyleplistfilereader.h <span style="color: grey">(1180207)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/lib/chatstyleplistfilereader.cpp <span style="color: grey">(1180207)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/chatstyleinstaller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/chatstyleinstaller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/CMakeLists.txt <span style="color: grey">(1180207)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/adiumxtra-protocol-handler.notifyrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/adiumxtra.protocol <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/bundleinstaller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/playground/network/telepathy-chat-handler/adiumxtra-protocol-handler/bundleinstaller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5483/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5483/s/514/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/29/2_400x100.png" style="border: 1px black solid;" alt="Chatstyle Installation" /></a>
<a href="http://svn.reviewboard.kde.org/r/5483/s/515/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/29/3_400x100.png" style="border: 1px black solid;" alt="Emoticonset Installation" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>