<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5467/">http://svn.reviewboard.kde.org/r/5467/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code looks OK so far. Was just going to test it out a bit but ran into problems with cmake - see comment below.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5467/diff/1/?file=38597#file38597line49" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> include/AccountEditWidget</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like you forgot to add this file to the patch :)</pre>
</div>
<br />
<p>- George</p>
<br />
<p>On September 28th, 2010, 7:17 p.m., Gustavo Boiko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for telepathy.</div>
<div>By Gustavo Boiko.</div>
<p style="color: grey;"><i>Updated 2010-09-28 19:17:50</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements the config scheme discussed in the mailing list. The account edit dialog now shows only one dialog containing all the main options for the protocol, and optionally an advanced button which opens one second dialog containing extra options.
There is no more distinction between mandatory and optional arguments, but the dialog ensures all mandatory arguments are handle, falling back to a generic dialog if they are not.
The patch also simplifies the loading of configuration widgets by creating the AccountEditDialog, which does all the job of loading the dialogs. This dialog is used by both the EditAccountDialog and the AddAccountWizard. It will also be used in the Kopete Telepathy plugin (I will work on this right after this one gets in).
The port of the plugins to this new scheme is already being done.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/optional-parameter-edit-widget.cpp <span style="color: grey">(1179066)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/protocol-item.h <span style="color: grey">(1180721)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/protocol-item.cpp <span style="color: grey">(1180721)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/add-account-assistant.cpp <span style="color: grey">(1179066)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/edit-account-dialog.h <span style="color: grey">(1179066)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/edit-account-dialog.cpp <span style="color: grey">(1179066)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/optional-parameter-edit-widget.h <span style="color: grey">(1179066)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/mandatory-parameter-edit-widget.h <span style="color: grey">(1179066)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/mandatory-parameter-edit-widget.cpp <span style="color: grey">(1179066)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/include/MandatoryParameterEditWidget <span style="color: grey">(1179066)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/include/OptionalParameterEditWidget <span style="color: grey">(1179066)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/CMakeLists.txt <span style="color: grey">(1180721)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/abstract-account-ui.h <span style="color: grey">(1180721)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/abstract-account-ui.cpp <span style="color: grey">(1180721)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/account-edit-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/account-edit-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/account-edit-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5467/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>