Review Request 117977: Fix for bug 333604 - icons in the presence chooser tooltip don't scale

Olaf Piesche opiesche at gmail.com
Sat May 3 18:44:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117977/
-----------------------------------------------------------

(Updated May 3, 2014, 6:44 p.m.)


Review request for Telepathy.


Changes
-------

Removed white space, added quotes for width and height in the <image> tag. Added screenshot.


Bugs: 333604
    http://bugs.kde.org/show_bug.cgi?id=333604


Repository: ktp-contact-list


Description
-------

Scaling icons in the presence chooser tool tip. The tooltip contains HTML, and the icons for accounts weren't scaled at all.


Diffs (updated)
-----

  global-presence-chooser.cpp 9eded30 

Diff: https://git.reviewboard.kde.org/r/117977/diff/


Testing
-------

Ran locally. Hovered until tooltip opened.


File Attachments (updated)
----------------

Screenshot of properly scaled icons
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/03/d814f132-44b3-4026-a99e-4a4320460420__tooltipicons.jpg


Thanks,

Olaf Piesche

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20140503/6aba0353/attachment.html>


More information about the KDE-Telepathy mailing list