Review Request 112430: Fix crash in AbstractGroupingModel when used in a tree

Commit Hook null at kde.org
Sun Sep 1 19:18:35 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112430/#review39093
-----------------------------------------------------------


This review has been submitted with commit fce5a536149cdaaa5945da423570e331207c5d27 by David Edmundson to branch master.

- Commit Hook


On Sept. 1, 2013, 4:03 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112430/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2013, 4:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix crash in AbstractGroupingModel when used in a tree
> 
> When removing a proxy item, remove children of that item from the proxy map
> 
> 
> Diffs
> -----
> 
>   KTp/Models/abstract-grouping-proxy-model.cpp 6978d9294300742bff951f13740a5f2572b241b0 
> 
> Diff: http://git.reviewboard.kde.org/r/112430/diff/
> 
> 
> Testing
> -------
> 
> Seems to fix that main crash we had in ktp-contact-list. I re-fed all my contacts, used the merge dialog with it open.. no crash.
> Though since running this it has still crashed once, however on a different error inside kpeople 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130901/4ac19181/attachment.html>


More information about the KDE-Telepathy mailing list