Review Request 109807: Stop using mission-control for autoconnect

Dominik Cermak d.cermak at arcor.de
Sun Mar 31 16:50:47 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109807/
-----------------------------------------------------------

Review request for Telepathy and David Edmundson.


Description
-------

Stop using mission-controls ConnectAutomatically for autoconnect, instead use our kded-module only.

The diff looks worse than it is. Most of the old code has been deleted, one new method has been added, but the unified diff mixes this all...


This addresses bug 307175.
    http://bugs.kde.org/show_bug.cgi?id=307175


Diffs
-----

  autoconnect.h e296012586a67aed88a87e2c166ff526ab0fa76d 
  autoconnect.cpp 526b060db162e81accb6da0d1d81cb6dd22c43c0 
  telepathy-module.cpp a28bca86f03e971ec7d68b62d69c8802d1b05677 

Diff: http://git.reviewboard.kde.org/r/109807/diff/


Testing
-------

Still testing if race conditions occur (auth-handler/kwallet timeout). So far no problems.


Thanks,

Dominik Cermak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130331/90bdc6b8/attachment.html>


More information about the KDE-Telepathy mailing list