Review Request 109490: fix grayed avatars part 2/2

David Edmundson david at davidedmundson.co.uk
Fri Mar 15 01:19:41 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109490/#review29247
-----------------------------------------------------------


That just means some numpty isn't including FeatureAvatarToken

- David Edmundson


On March 14, 2013, 11:30 p.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109490/
> -----------------------------------------------------------
> 
> (Updated March 14, 2013, 11:30 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Martin Klapetek.
> 
> 
> Description
> -------
> 
> using avatarToken for keyCache ends up with "-offline" for all grayed avatars as cache entries.. which is obviously wrong... I used id() instead... Martin's original idea.
> 
> 
> This addresses bug 316743.
>     http://bugs.kde.org/show_bug.cgi?id=316743
> 
> 
> Diffs
> -----
> 
>   KTp/contact.cpp 84ae642 
> 
> Diff: http://git.reviewboard.kde.org/r/109490/diff/
> 
> 
> Testing
> -------
> 
> build and now offline avatars are correctly grayed.
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130315/5e6b1391/attachment.html>


More information about the KDE-Telepathy mailing list