Review Request 109231: new method for KTp::Contact avatarPixmap() part 1

Alin M Elena alinm.elena at gmail.com
Fri Mar 1 17:15:58 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109231/
-----------------------------------------------------------

(Updated March 1, 2013, 5:15 p.m.)


Review request for Telepathy, David Edmundson and Dan Vrátil.


Changes
-------

diff updated with some of Martin's concerns


Description
-------

adds a method avatarPixmap() to KTp::Contact which returns a colour or gray pixmap based on presence, to be used by contact list.


This addresses bug 315965.
    http://bugs.kde.org/show_bug.cgi?id=315965


Diffs (updated)
-----

  KTp/Models/contacts-list-model.cpp 692bcfd 
  KTp/contact.h c332c7d 
  KTp/contact.cpp 0602200 
  KTp/types.h 4ef0002 

Diff: http://git.reviewboard.kde.org/r/109231/diff/


Testing
-------

implemented in contact list and works... 


Thanks,

Alin M Elena

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130301/46ae97d7/attachment.html>


More information about the KDE-Telepathy mailing list