Review Request: Fixes the bug that states when blocking a contact "typing" status should be cleared and two other bugfixes that was reported in the IRC.

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104451/#review12083
-----------------------------------------------------------


Patch looks ok, but please disable the block/unblock action if a chat is a group chat


app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104451/#comment9523>

    Since you are using it just here you can do, it will save the allocation of the string setWindowTitle(currChat->title());



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/104451/#comment9522>

    Fix alignment here


Also this time Martin will agree that the patch requires 3 separate commits, so push it somewhere this time :P

Related bugs are:
https://bugs.kde.org/show_bug.cgi?id=297187 Crash when blocking contact on group chats
https://bugs.kde.org/show_bug.cgi?id=297188 Sending a message to a blocked contact should report that the contact is blocked
https://bugs.kde.org/show_bug.cgi?id=297191 When blocking a contact "typing" status should be cleared

- Daniele Elmo Domenichelli


On March 31, 2012, 10:14 p.m., Ahmed Ibrahim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104451/
> -----------------------------------------------------------
> 
> (Updated March 31, 2012, 10:14 p.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> Fixes the crash that happens when Blocking a contact during a group chat.
> Display to the user "The remote contact is blocked" string instead of the one that is printed when the user offline.
> Fixes Bug 297191 - When blocking a contact "typing" status should be cleared.
> 
> 
> This addresses bug 297191.
>     http://bugs.kde.org/show_bug.cgi?id=297191
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp ee62869 
>   lib/chat-widget.cpp cfbb74b 
> 
> Diff: http://git.reviewboard.kde.org/r/104451/diff/
> 
> 
> Testing
> -------
> 
> Blocked a user while typing status is displayed, the window title resets.
> 
> 
> Thanks,
> 
> Ahmed Ibrahim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120331/525df540/attachment.html>