Review Request: Block/Unblock feature in ktp-text-ui module.

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104407/#review11871
-----------------------------------------------------------


Please fix the coding style (see http://techbase.kde.org/Policies/Kdelibs_Coding_Style )


app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9421>

    Please avoid trailing white spaces (there are several in other places, but I'll comment just on this)



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9422>

    } else {



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9425>

    } else {



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9426>

    } else {



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9423>

    check the indentation



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9427>

    } else {



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9428>

    Move the comment in the next line and split it in 2 lines to make it more readable



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9429>

    same



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9430>

    This line is not needed



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9424>

    indentation


The patch itself looks good, but I will review it again when the coding style is fixed...

- Daniele Elmo Domenichelli


On March 25, 2012, 10:52 p.m., Ahmed Ibrahim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104407/
> -----------------------------------------------------------
> 
> (Updated March 25, 2012, 10:52 p.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> Added Block/Unblock contact button to the KActionCollection of the ktp-text-ui.
> Added also code that will help in displaying blocking/unblocking actions to the user in the ChatView.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=292402.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=292402
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp 75dd968 
>   app/chat-window.h 8ee4463 
>   app/chatwindow.rc f65fbd1 
>   app/main.cpp d76ce04 
>   lib/channel-contact-model.h 41d5d84 
>   lib/channel-contact-model.cpp d731322 
>   lib/chat-widget.h e1efbbb 
>   lib/chat-widget.cpp bb1f5ef 
> 
> Diff: http://git.reviewboard.kde.org/r/104407/diff/
> 
> 
> Testing
> -------
> 
> Blocked a contact and found that is blocked in another IM client and had other opened tabs and the button was changing according to the user's block state 
> 
> 
> Thanks,
> 
> Ahmed Ibrahim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120326/2d9cad2a/attachment.html>