Review Request: Add SSH Contact filtering

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104265/#review11378
-----------------------------------------------------------

Ship it!


Fine to ship this, but: This needs to change to be more generic.


KTp/Models/accounts-model.h
<http://git.reviewboard.kde.org/r/104265/#comment9105>

    Long term we can't make a new role for every new stream tube.
    
    It doesn't make sense to recompile the common library each time someone adds Telepathy support to an app.



KTp/Models/contact-model-item.cpp
<http://git.reviewboard.kde.org/r/104265/#comment9104>

    Why can't you do it the same way we do audio/video?
    
    if me->capabilities().streamTubes(QLatin1String("x-ssh-contact")); 
    
    


- David Edmundson


On March 13, 2012, 11:46 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104265/
> -----------------------------------------------------------
> 
> (Updated March 13, 2012, 11:46 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add "SSH Contact" filtering to the models
> 
> 
> Diffs
> -----
> 
>   KTp/Models/accounts-filter-model.h c23b2843b6ff5a431c4cca275005c1cb4a9ad498 
>   KTp/Models/accounts-filter-model.cpp 5beb201c1a91ef3347f338d7b5301df372833dc5 
>   KTp/Models/accounts-model.h a67912d9d4a727da3556a628295cf2e50f49da1e 
>   KTp/Models/accounts-model.cpp 51fca8802d1522f0b3ed57414c749e8ae0255ece 
>   KTp/Models/contact-model-item.h 4d8ce512de9541c1013aa5cd38859a9bfd45f1f6 
>   KTp/Models/contact-model-item.cpp 50145688be749d0bbb83d814ce99f4f02ec387a8 
> 
> Diff: http://git.reviewboard.kde.org/r/104265/diff/
> 
> 
> Testing
> -------
> 
> Works, but at the moment I don't know how to check if ssh-contact is installed
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120313/98b82754/attachment.html>