KTp Contact runner

[Dan Vratil]

On Sunday 11 of March 2012 23:12:43 David Edmundson wrote:
> Nicely done. I'm all for getting this into 0.4.

<snip>
> 
> 4)
> 
> Also I'm not sure I like this idea of showing the avatar if there's
> one available, otherwise showing the status. If the user has an avatar
> you wouldn't get to see their status which is a bit lame. Maybe some
> sort of overlay of presence on top of avatar.

As discussed on IRC, the status is displayed in the second line below the 
contact's so I dont' think it's a problem. Also, spotting the right contact by 
it's avatar seems much more user-friendly to me than having to read the name 
every time.

I've fixed the other issues in git, thanks a lot for the review.

If you have no objections, I would then request a git repo in 
extragear/telepathy and move it there by tomorrow or on Tuesday.


Thanks again,

Dan

> 
> 
> Misc brainstorming:
> This may be wrong but; rather than keeping an entire model up to date
> constantly in krunner, it may be less wasteful to query each
> ContactManager for alContacts() each time in match(). Obviously that's
> a very large rewrite, so I'm not really suggesting you do it, just
> thinking out loud. I'm not even sure you can do async stuff in
> AbstractRunner::match().
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy at kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy
-- 
Dan Vratil
www.progdan.cz | dan at progdan.cz | Jabber: progdan at jabber.cz
Fingerprint: 76C9 2F08 5D0D 6F9E 5AD4 2BFD 3A85 0307 F506 5B61
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120312/8bdd67f4/attachment.sig>