Review Request: Port Presence Data Engine to tp-qt4 0.5, and add Services and Properties

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100968/
-----------------------------------------------------------

(Updated March 29, 2011, 2:29 p.m.)


Review request for Telepathy.


Changes
-------

Addressed David's comments


Summary
-------

This patch ports the data engine to Telepathy Qt4 0.5.x, and adds new Service operations for setting avatars and nicknames. It also enhances data retrieval and fixes some small bugs here and there.


Diffs (updated)
-----

  CMakeLists.txt 409c6135e53ecee63f02a756a9c0d8c5c399fe4e 
  plasma-dataengine-presence.desktop 7a850af570113882b1d8c3509e3c260a2fc77353 
  presence.h eb5d6dac20a9e7469508d4b87bb7fd02a5624c24 
  presence.cpp 179c8055bbf29bd17eb80faf8fd14a8549a453a9 
  presence.operations 0aed15758af9cab6780bd8b31822ce991d045983 
  presenceservice.cpp d7a9a64d3b04acbb5ae19c9b7194c2f47efae74c 
  presencesource.h 586b70f258d7b9bd0bc239aba25b599a038cfd4a 
  presencesource.cpp fdab2c400e8833844c7feed71d77927acd9160cf 
  setavatarjob.h PRE-CREATION 
  setavatarjob.cpp PRE-CREATION 
  setnicknamejob.h PRE-CREATION 
  setnicknamejob.cpp PRE-CREATION 
  setrequestedpresencejob.h 40c2ca1f5abff5d82c49f9ac1019b162e9249128 
  setrequestedpresencejob.cpp 0a77a48941ab41cebe59b6646ba5bbde796ad7a4 

Diff: http://git.reviewboard.kde.org/r/100968/diff


Testing
-------

Engine explorer works flawlessly


Thanks,

Dario

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110329/c3669391/attachment-0001.htm