Review Request: Don't detect typing in chat-widget when we can't use it

Florian Reinhard florian.reinhard at googlemail.com
Fri Mar 18 12:33:23 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100886/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Let's save some cpu cylcles and don't detect typing in chat-widget when we can't use it.


Diffs
-----

  config/kcm_telepathy_chat_config.desktop 7641c3a2af38ffd0c426185461bc82aa3f95fcb2 
  lib/adium-theme-view.cpp 0133f3d0309147083a91773be37d72d016ace08d 
  lib/chat-widget.cpp 6ea639b0b3696030bd76bba219522abf70aef400 
  lib/chat-window-style.cpp e5003ec7acf1f02e6eed178773aafc02dad82228 

Diff: http://git.reviewboard.kde.org/r/100886/diff


Testing
-------

no more warnings like this on cli:
tp-qt4 0.5.11.1 WARN: TextChannel::requestChatState() used with no chat state interface


Thanks,

Florian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110318/4ee9a58a/attachment.htm 


More information about the KDE-Telepathy mailing list