Review Request: Delete ChatWidgets when removed from ChatWindow's tab bar

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100793/#review1739
-----------------------------------------------------------

Ship it!


Looks sensible to me.


app/chatwindow.h
<http://git.reviewboard.kde.org/r/100793/#comment1433>

    Why are any of this public slots? 
    
    Remind me to fix this at a later date.


- David


On March 2, 2011, 11:38 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100793/
> -----------------------------------------------------------
> 
> (Updated March 2, 2011, 11:38 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> When a tab was removed from chat window, the widget itself wasn't deleted, even though it seems it should have been.
> 
> As I don't know the code base that well, I feel insecure about if there are any pointers to ChatWidgets elsewhere than in the tab bar. Probably not, but still.
> 
> 
> Diffs
> -----
> 
>   app/chatwindow.h 663a54a 
>   app/chatwindow.cpp fed4381 
> 
> Diff: http://git.reviewboard.kde.org/r/100793/diff
> 
> 
> Testing
> -------
> 
> Compiles and doesn't crash when a tab is removed by clicking on its close button.
> 
> 
> Thanks,
> 
> Lasse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110303/e70ad253/attachment.htm