Review Request: Removed an unused method removeContact(), which had very crashy-prone code in it.

Martin Klapetek martin.klapetek at gmail.com
Mon Jun 27 10:45:05 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101761/#review4193
-----------------------------------------------------------

Ship it!



models/groups-model-item.cpp
<http://git.reviewboard.kde.org/r/101761/#comment3423>

    Probably could use one more press of the delete-key on this line ;)


- Martin


On June 26, 2011, 12:17 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101761/
> -----------------------------------------------------------
> 
> (Updated June 26, 2011, 12:17 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Removed an unused method removeContact(), which had very crashy-prone code in it anyway.
> 
> 
> Diffs
> -----
> 
>   models/groups-model-item.h 7fe99ccfd95a083d8bcc1f9c81c60fd1f520c2be 
>   models/groups-model-item.cpp f01a7d6714b05f063d726ed651166f4eae59751a 
> 
> Diff: http://git.reviewboard.kde.org/r/101761/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110627/06ad8053/attachment.htm 


More information about the KDE-Telepathy mailing list