Review Request: Create custom menu for links

David Edmundson kde at davidedmundson.co.uk
Sun Jul 17 19:20:25 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101976/#review4766
-----------------------------------------------------------

Ship it!


A damn good patch.

Could you revert this one change below (or explain why you made it) before committing.


lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/101976/#comment4152>

    Not sure why you changed this.
    


- David


On July 17, 2011, 3:59 p.m., Paolo Capriotti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101976/
> -----------------------------------------------------------
> 
> (Updated July 17, 2011, 3:59 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Changed action OpenLink to use KToolInvocation.
> Removed irrelevant actions from context menu.
> Fixes http://bugs.kde.org/show_bug.cgi?id=276879.
> 
> 
> Diffs
> -----
> 
>   lib/adium-theme-view.h 1810720 
>   lib/adium-theme-view.cpp 991bed3 
> 
> Diff: http://git.reviewboard.kde.org/r/101976/diff
> 
> 
> Testing
> -------
> 
> Links are now opened in the default browser both when clicking and when using the context menu.
> 
> 
> Thanks,
> 
> Paolo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110717/d01875fd/attachment.htm 


More information about the KDE-Telepathy mailing list