Review Request: Fix krazy issues in common-internals

Martin Klapetek martin.klapetek at gmail.com
Fri Dec 16 11:23:35 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103420/#review8995
-----------------------------------------------------------

Ship it!


Looking at the email addresses, we should probably unite them everywhere to use machine readable emails. The email address can be extracted from git logs anyway, so there's no point in obfuscating them in the code (and making it harder for normal people to use). If anyone disagrees, let me know, otherwise I'll change them everywhere.

- Martin Klapetek


On Dec. 15, 2011, 6:27 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103420/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2011, 6:27 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix ambiguous translations.
> Make constructor explicit.
> Fix typo.
> Fix Copyright headers.
> 
> 
> Diffs
> -----
> 
>   KTelepathy/Models/groups-model-item.h fefcde0 
>   KTelepathy/Models/groups-model-item.cpp d4363b0 
>   KTelepathy/Models/groups-model.h 23f5c3f 
>   KTelepathy/Models/groups-model.cpp ad363d2 
>   KTelepathy/presence.cpp b9e6aff 
>   KTelepathy/service-availability-checker.h fad1fc5 
>   KTelepathy/text-parser.h 37eed91 
> 
> Diff: http://git.reviewboard.kde.org/r/103420/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111216/f0617b2c/attachment.html>


More information about the KDE-Telepathy mailing list