Review Request: Allow copy of text in the chat by pressing Ctrl+C and reorganize the key handling a bit.

Jan Gerrit Marker jangerrit at weiler-marker.com
Wed Aug 3 10:45:50 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102193/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

The patch was created with the purpose to enable text copying by pressing Ctrl+C. This was more complicated than I thought so I tried to implement a new concept of handling the keys:
My goal was to let the line edit and the view behave like there were one widget regarding text selection. If text in the line edit is marked there is no text marked in the view and vice versa. In order to achieve this I let the widget which contains both handle the key events by connecting to a signal in the two classes which get's emitted when a key is pressed.


Diffs
-----

  lib/adium-theme-view.h 0507128 
  lib/adium-theme-view.cpp 0eb1090 
  lib/chat-text-edit.h c086010 
  lib/chat-text-edit.cpp ea96034 
  lib/chat-widget.h 06e98a1 
  lib/chat-widget.cpp 534ee1c 

Diff: http://git.reviewboard.kde.org/r/102193/diff


Testing
-------

I tested it for a day and there were no problems.


Thanks,

Jan Gerrit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110803/5f5c5f9a/attachment-0001.html>


More information about the KDE-Telepathy mailing list