Review Request: Initial implementation of telepathy-approver

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100199/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

This is the initial implementation of the approver. It can approve p2p text chats only, for now. It is build as a kded module. When a new message arrives, it shows a knotify popup, it plays a sound and shows a KStatusNotifierItem flashing in the tray.

gitweb url:
http://gitweb.kde.org/clones/telepathy-approver/gkiagia/telepathy-approver.git/shortlog/refs/heads/implementation


Diffs
-----

  CMakeLists.txt PRE-CREATION 
  src/CMakeLists.txt PRE-CREATION 
  src/approverdaemon.h PRE-CREATION 
  src/approverdaemon.cpp PRE-CREATION 
  src/channelapprover.h PRE-CREATION 
  src/channelapprover.cpp PRE-CREATION 
  src/dispatchoperation.h PRE-CREATION 
  src/dispatchoperation.cpp PRE-CREATION 
  src/handlewithcaller.h PRE-CREATION 
  src/handlewithcaller.cpp PRE-CREATION 
  src/telepathy_kde_approver.desktop PRE-CREATION 
  src/telepathy_kde_approver.notifyrc PRE-CREATION 
  src/textchannelapprover.h PRE-CREATION 
  src/textchannelapprover.cpp PRE-CREATION 
  src/tpkdeapprovermodule.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100199/diff


Testing
-------

Tested with empathy as the chat handler. Currently the "respond" button on the popup doesn't seem to work, but I blame knotify's crappiness for that. Clicking on the flashing icon works perfectly, though.


Thanks,

George

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20101209/212c5ee9/attachment.htm