<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29602">View Revision</a></tr></table><br /><div><div><p>Tried it locally and it's pretty cool. Just some nitpicks in the recent changes.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29602#inline-170398">View Inline</a><span style="color: #4b4d51; font-weight: bold;">storagemodel.cpp:260</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QHash</span><span style="color: #aa2211"><</span><span class="n">Akonadi</span><span style="color: #aa2211">::</span><span class="n">Collection</span><span style="color: #aa2211">::</span><span class="n">Id</span><span class="p">,</span> <span class="n">QString</span><span style="color: #aa2211">>::</span><span class="n">iterator</span> <span class="n">it</span> <span style="color: #aa2211">=</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mFolderHash</span><span class="p">.</span><span class="n">find</span><span class="p">(</span><span class="n">item</span><span class="p">.</span><span class="n">storageCollectionId</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use <tt style="background: #ebebeb; font-size: 13px;">auto</tt> instead of typing out the entire iterator type, please.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29602#inline-170400">View Inline</a><span style="color: #4b4d51; font-weight: bold;">storagemodel.cpp:270</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">it</span> <span style="color: #aa2211">=</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mFolderHash</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">item</span><span class="p">.</span><span class="n">storageCollectionId</span><span class="p">(),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                   <span class="n">folder</span><span class="p">.</span><span class="n">left</span><span class="p">(</span><span class="n">folder</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This does an unnecessary copy of the substring, I'd propose to do <tt style="background: #ebebeb; font-size: 13px;">folder.chop(1)</tt> after the while loop, which just shrinks the current string, then you can insert it directly into the hash table.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R94 PIM: Message Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29602">https://phabricator.kde.org/D29602</a></div></div><br /><div><strong>To: </strong>gordin, VDG, dvratil<br /><strong>Cc: </strong>dvratil, kde-pim, jamesth, fbampaloukas, dvasin, hrouis, rodsevich, ach, winterz, vkrause, mlaurent, knauss<br /></div>