<table><tr><td style="">nhiga added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29223">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>On the Spring festival 春節 of 2020, the publicholidays.tw page and the official source listed on that page both showed Jan 23 to 29 as the days off.</p></blockquote>
<p>I think both of us can be correct:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">I referred to <a href="https://www.moi.gov.tw/files/news_file/109%E5%B9%B4%E6%87%89%E6%94%BE%E5%81%87%E4%B9%8B%E7%B4%80%E5%BF%B5%E6%97%A5%E5%8F%8A%E7%AF%80%E6%97%A5(odt).odt" class="remarkup-link" target="_blank" rel="noreferrer">this document by Ministry of the Interior, R. O. C. (Taiwan) for 2020</a>. I believe that document is showing the "minimum requirements by law", which means all employees should be able to haves days off on the listed holidays.</li>
<li class="remarkup-list-item">For government offices, I believe that the regulations "政府機關調整上班日期處理要點" will be applied and civil servants have extra days off in some conditions. For example it says " 四、上班日為星期一或星期五，其後一日或前一日逢星期二或星期四之紀念日及節日之放假，調整該上班日為放假日。農曆除夕前一日為上班日者，調整該上班日為放假日。 ", so I think this is why Jan 23 is also a day off for them.</li>
</ul>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Would you also indicate the plan for the festivals specified as "2020" in this diff for future years?</p></blockquote>
<p>I plan to follow the format in the <tt style="background: #ebebeb; font-size: 13px;">holiday_hk_*</tt> files, so it will be something like:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">:: 應放假之紀念日及節日（以農曆為基礎）
: Chinese New Year's Eve
"農曆除夕" public cultural on 24 January 2020
: Spring festival
"春節" public cultural on 25 January 2020 length 5 days
: Tomb Sweeping Day
"民族掃墓節" public cultural on 4 April 2020
: Dragon Boat Festival
"端午節" public cultural on 25 June 2020
: Mid-Autumn Festival
"中秋節" public cultural on 1 October 2020
"農曆除夕" public cultural on DD MM 2021
"春節" public cultural on DD MM 2021 length Y days
"民族掃墓節" public cultural on DD MM 2021
"端午節" public cultural on DD MM 2021
"中秋節" public cultural on DD MM 2021
:: Substitute holidays
:: 補假
"兒童節補假" public on 3 April 2020
"民族掃墓節補假" public on 2 April 2020
"XX補假" public on DD MM 2021
"XX補假" public on DD MM 2021</pre></div></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29223#inline-168130">View Inline</a><span style="color: #4b4d51; font-weight: bold;">weisi</span> wrote in <span style="color: #4b4d51; font-weight: bold;">holiday_tw_zh-tw:38</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Do you intend to use 3 days here?</p>
<p style="padding: 0; margin: 8px;">According to <a href="https://law.moj.gov.tw/LawClass/LawAll.aspx?pcode=D0020033" class="remarkup-link" target="_blank" rel="noreferrer">紀念日及節日實施辦法</a>:</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">下列民俗節日，除春節放假三日外，其餘均放假一日... (3 days off for the Spring festival, 1 day off otherwise, for the following...)</p></blockquote></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I intentionally included substitute holidays (Jan 28-29 2020) when writing the length, since <tt style="background: #ebebeb; font-size: 13px;">holiday_hk_*</tt>also include substitute holidays in the length for Spring Festival.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29223#inline-168128">View Inline</a><span style="color: #4b4d51; font-weight: bold;">weisi</span> wrote in <span style="color: #4b4d51; font-weight: bold;">holiday_tw_zh-tw:62</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I think this one is more religious than commemorative.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">True. Maybe mark it as "religious commemorative"?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R175 KHolidays</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29223">https://phabricator.kde.org/D29223</a></div></div><br /><div><strong>To: </strong>nhiga, winterz, cgiboudeaux, shrapnel<br /><strong>Cc: </strong>weisi, KDE PIM, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>