<table><tr><td style="">andreylegayev marked 3 inline comments as done.<br />andreylegayev added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28580">View Revision</a></tr></table><br /><div><div><p><a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> now I know that I need to click "Submit" :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28580#inline-163596">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">mainwindow.cpp:706</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Shorter form:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">setVisible(cfgGroup.readEntry("hidden", false));</pre></div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Replaced, but <tt style="background: #ebebeb; font-size: 13px;">setHidden()</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28580#inline-163597">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">mainwindow.cpp:696</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">The code to load autosaved settings is the end of KMainWindow::setAutoSaveSettings.<br />
This works for all other KMainWindow-based applications, you know ;)</p>
<p style="padding: 0; margin: 8px;">To enable the autosave functionality, you call setAutoSaveSettings at creation time, and it will load the previously saved settings.</p>
<p style="padding: 0; margin: 8px;">readProperties and saveProperties are called from here, so obviously not just for session management purposes.</p>
<p style="padding: 0; margin: 8px;">I would really like kleopatra to do like all other KMainWindow-based applications and rely on the KMainWindow code as much as possible. This makes long term maintenance easier.</p>
<p style="padding: 0; margin: 8px;">I see that we're missing something similar for dialogs, which means we should have something in a KDE Frameworks about that, but for now I'm ok with your solution of duplicating a bit of code in every one of kleopatra's dialogs. For the mainwindow, though, I'd like it to do the right thing since that is available.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Thanks for the hint with setAutoSaveSettings(). I've added it to constructor.<br />
I've reverted back the rest to original version, but removed geometry save/load.</p>
<p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">readProperties</tt> and <tt style="background: #ebebeb; font-size: 13px;">saveProperties</tt> are really called only from session management. <br />
I've re-checked it by setting breakpoints and by investigating source code:<br />
<a href="https://github.com/vasi/kdelibs/blob/master/kdeui/widgets/kmainwindow.cpp" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/vasi/kdelibs/blob/master/kdeui/widgets/kmainwindow.cpp</a></p>
<p style="padding: 0; margin: 8px;">Call chain from constructor - <tt style="background: #ebebeb; font-size: 13px;">readProperties()</tt> isn't called:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">1. setAutoSaveSettings()
2. applyMainWindowSettings()</pre></div>
<p style="padding: 0; margin: 8px;">Call chain from session management:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">1. restore()
2. readPropertiesInternal()
3. applyMainWindowSettings() + readProperties()</pre></div>
</div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R168 Kleopatra</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28580">https://phabricator.kde.org/D28580</a></div></div><br /><div><strong>To: </strong>andreylegayev, dfaure<br /><strong>Cc: </strong>dfaure, mlaurent, kde-pim, andreylegayev, fbampaloukas, dcaliste, dvasin, rodsevich, ach, winterz, vkrause, knauss, dvratil<br /></div>