<table><tr><td style="">andreylegayev marked an inline comment as done.<br />andreylegayev added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28580">View Revision</a></tr></table><br /><div><div><p><a href="https://phabricator.kde.org/p/dfaure/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dfaure</a> could you review my comments?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28580#inline-162768">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mlaurent</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kleopatraapplication.cpp:111</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">not the same patch as it.<br />
Create another one please</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Done: <a href="https://phabricator.kde.org/D28591" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D28591</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28580#inline-162872">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kleopatraapplication.cpp:227</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">This if() is not needed.<br />
<tt style="background: #ebebeb; font-size: 13px;">delete nullptr</tt> is valid in C++ (no-op).</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Fixing it.. thanks!</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28580#inline-162873">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in <span style="color: #4b4d51; font-weight: bold;">mainwindow.cpp:696</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Is this needed? Unlike the dialogs above in this patch, this class is a KXmlGuiWindow which inherits from KMainWindow which has this code already.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I agree - MainWindow inherits it from KMainWindow, but it works only with KDE session management.<br />
Methods <tt style="background: #ebebeb; font-size: 13px;">readProperties()</tt> and <tt style="background: #ebebeb; font-size: 13px;">saveProperties()</tt> are called when you save session (this is how I debugged it) and when you run app with parameter <tt style="background: #ebebeb; font-size: 13px;">-session</tt></p>
<p style="padding: 0; margin: 8px;">There is also builtin timer which saves window settings automatically once you resize window, but there is no code which loads saved settings.<br />
If you run most recent Kleopatra on your machine you'll get window size 1024x500 regardless previously saved size.</p>
<p style="padding: 0; margin: 8px;">In this class I could call KMainWindow methods directly, but I wanted to have universal code snippet for all windows to save geometry on multi-dpi/-screen without annoying Qt bug. I re-used it in dialogs as you saw.</p>
<p style="padding: 0; margin: 8px;">Annoying Qt bug - win10:<br />
I literally cannot make SignEncrypt window appear to me. <br />
The only way is to delete <tt style="background: #ebebeb; font-size: 13px;">geometry</tt> from kleopatrarc and restart Kleopatra.<br />
It so annoyed me that I configured dev environment and started all this debug :-)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R168 Kleopatra</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28580">https://phabricator.kde.org/D28580</a></div></div><br /><div><strong>To: </strong>andreylegayev, dfaure<br /><strong>Cc: </strong>dfaure, mlaurent, kde-pim, andreylegayev, fbampaloukas, dcaliste, dvasin, rodsevich, ach, winterz, vkrause, knauss, dvratil<br /></div>