<table><tr><td style="">poboiko created this revision.<br />poboiko added reviewers: dvratil, mlaurent.<br />Herald added a project: KDE PIM.<br />poboiko requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27722">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p><tt style="background: #ebebeb; font-size: 13px;">ConfigWidget</tt> uses <tt style="background: #ebebeb; font-size: 13px;">KConfig</tt> underneath, and utilizes <tt style="background: #ebebeb; font-size: 13px;">KUrlRequester</tt> custom<br />
widget. The <tt style="background: #ebebeb; font-size: 13px;">USER</tt> property of this widget (which is used by <tt style="background: #ebebeb; font-size: 13px;">KConfig</tt>) is of<br />
type <tt style="background: #ebebeb; font-size: 13px;">QUrl</tt>, and thus when dialog is accepted, the <tt style="background: #ebebeb; font-size: 13px;">path</tt> config property<br />
gets overriden with <tt style="background: #ebebeb; font-size: 13px;">QUrl::toString()</tt> value, which prepends <tt style="background: #ebebeb; font-size: 13px;">file:</tt> schema<br />
(this is basically because <tt style="background: #ebebeb; font-size: 13px;">KCoreConfigSkeleton::ItemPath</tt> is inherited from<br />
<tt style="background: #ebebeb; font-size: 13px;">ItemString</tt>, and when someone calls <tt style="background: #ebebeb; font-size: 13px;">ItemString::setProperty</tt>, it gets<br />
casted as <tt style="background: #ebebeb; font-size: 13px;">QVariant::toString</tt>).</p>
<p>Inside the <tt style="background: #ebebeb; font-size: 13px;">ConfigWidget::save</tt> the code calls <tt style="background: #ebebeb; font-size: 13px;">setPath</tt> method on<br />
<tt style="background: #ebebeb; font-size: 13px;">url.toLocalFile</tt>, which drops the scheme. Because of that, the <tt style="background: #ebebeb; font-size: 13px;">pathItem</tt><br />
and <tt style="background: #ebebeb; font-size: 13px;">path</tt> property of <tt style="background: #ebebeb; font-size: 13px;">mSettings</tt> have different values, first has schema<br />
and the second hasn't. Eventually, the value stored by <tt style="background: #ebebeb; font-size: 13px;">pathItem</tt> wins, and<br />
<tt style="background: #ebebeb; font-size: 13px;">mSettings->path()</tt> returns URL with schema. However, <tt style="background: #ebebeb; font-size: 13px;">Maildir</tt> doesn't expect<br />
it and misinterprets it as the relative path to current WORKDIR (which is home<br />
directory), thus creating <tt style="background: #ebebeb; font-size: 13px;">/home/user/file:/home/user/...</tt> file structure.</p>
<p>The proposed solution is to simply call <tt style="background: #ebebeb; font-size: 13px;">mSettings->save()</tt>, which overrides<br />
<tt style="background: #ebebeb; font-size: 13px;">pathItem</tt> value and drops schema from it.</p>
<p>It also fixes the <tt style="background: #ebebeb; font-size: 13px;">AkoNotes</tt> resource, which uses the same <tt style="background: #ebebeb; font-size: 13px;">ConfigWidget</tt>.<br />
Funny enough, <tt style="background: #ebebeb; font-size: 13px;">Contacts</tt> resource, which is somewhat similar, is not affected<br />
as it has the same <tt style="background: #ebebeb; font-size: 13px;">Settings->save()</tt> call.</p>
<p>Alternative approaches include:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Teach <tt style="background: #ebebeb; font-size: 13px;">Maildir</tt> to drop the schema (if it's there).</li>
<li class="remarkup-list-item">Teach <tt style="background: #ebebeb; font-size: 13px;">KCoreConfigSkeleton::ItemPath</tt> to work with <tt style="background: #ebebeb; font-size: 13px;">QUrl</tt> and don't append</li>
</ol>
<p>schema (it makes sense, because <tt style="background: #ebebeb; font-size: 13px;">ItemPath</tt> corresponds to local file. Although<br />
it's not documented that it shouldn't have schema, it seems from the tests that<br />
it was the original intent). This could save the headache of having such issue<br />
in the future, but it could mess up with other programs in funny ways (as<br />
currently <tt style="background: #ebebeb; font-size: 13px;">file:</tt> sometimes gets prepended, and some code might implicitly rely<br />
on it)</p>
<p>Additional note:<br />
There are <tt style="background: #ebebeb; font-size: 13px;">ui.kcfg_Path->url().isLocalFile()</tt> checks around, which doesn't make<br />
sense to me, as <tt style="background: #ebebeb; font-size: 13px;">KUrlRequester</tt> is used for local files and it seems like it<br />
always returns <tt style="background: #ebebeb; font-size: 13px;">QUrl</tt> pointing to local file (i.e. have the <tt style="background: #ebebeb; font-size: 13px;">file:</tt> schema).</p>
<p>BUG: 408354<br />
BUG: 411269<br />
BUG: 413588</p></div></div><br /><div><strong>TEST PLAN</strong><div><ol class="remarkup-list">
<li class="remarkup-list-item">Open <tt style="background: #ebebeb; font-size: 13px;">akonadiconsole -> Local Folders</tt> properties, change the folder, save</li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">cat ~/.config/akonadi_maildir_resource_0rc</tt>. <tt style="background: #ebebeb; font-size: 13px;">file:</tt> schema gets prepended</li>
</ol>
<p>2.1) <tt style="background: #ebebeb; font-size: 13px;">akonadictl restart</tt>. <tt style="background: #ebebeb; font-size: 13px;">file:</tt> folder gets created inside homedir</p>
<ol class="remarkup-list" start="3">
<li class="remarkup-list-item">Apply patch, repeat (1)-(2.1). <tt style="background: #ebebeb; font-size: 13px;">file:</tt> schema is dropped.</li>
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R44 KDE PIM Runtime</div></div></div><br /><div><strong>BRANCH</strong><div><div>scheme-bug (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27722">https://phabricator.kde.org/D27722</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>resources/maildir/configwidget.cpp</div></div></div><br /><div><strong>To: </strong>poboiko, dvratil, mlaurent<br /><strong>Cc: </strong>kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>