<table><tr><td style="">gbs created this revision.<br />gbs added a reviewer: mlaurent.<br />Herald added a project: KDE PIM.<br />Herald added a subscriber: kde-pim.<br />gbs requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27062">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>According to <a href="https://developers.google.com/calendar/v3/errors" class="remarkup-link" target="_blank" rel="noreferrer">https://developers.google.com/calendar/v3/errors</a>, the server can return a 410 error if the syncToken or updatedMin is too old.<br />
There is already code to preemptively request a full sync, but specifically for the "Contacts" calendar the server-side limit is much lower than usual, generating these errors and preventing sync.</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Set last sync for "Contacts" calendar to five days ago.</li>
<li class="remarkup-list-item">Observe 410 error being returned.</li>
<li class="remarkup-list-item">Verify that a full sync is performed.</li>
</ul>
</div></div><br /><div><strong>REPOSITORY</strong><div><div>R477 KGAPI Library</div></div></div><br /><div><strong>BRANCH</strong><div><div>release/19.12</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27062">https://phabricator.kde.org/D27062</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/calendar/eventfetchjob.cpp<br />
src/core/job.cpp</div></div></div><br /><div><strong>To: </strong>gbs, mlaurent<br /><strong>Cc: </strong>kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>