<table><tr><td style="">winterz updated this revision to Diff 67971.<br />winterz edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-7mvcrluoofl3dqr/">(Show Details)</a><br />winterz edited the test plan for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-vbzeph7gw5735cz/">(Show Details)</a><br />winterz added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24633">View Revision</a></tr></table><br /><div><div><p>Thanks to <span class="phabricator-remarkup-mention-unknown">@montel</span> for mentoring me :)<br />
<a href="https://phabricator.kde.org/F7600276" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7600276: KNS3.png</a></p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div> <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">- we</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">-</span> need to <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">set</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">pass</span> the <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">ap</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">ex</span>plic<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">ation</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">it</span> name<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">, version etc,</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> of the .knsrc file</span> else KNS3 <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">was looking for kontact.knsrc and not korganizer</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">thinks we want the kontact</span>.knsrc<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"><br />
<br />
hmm... maybe it isn't a good idea to set the ApplicationName, Version, etc. in here since that's a global thing and may break other stuff.<br />
I don't see an API for KNS3 that allows setting the applicationName, version.. . that would be better if there was such an API.</span><br />
<br />
<br />
<br />
</div></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div style="white-space: pre-wrap; color: #74777D;">seems to work now. <br />
<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">the more I think about it the more I know setting QApplicationName , etc in here is not correct.<br />
<br />
I think I'll make a new patch with saves and resets those values.<br />
</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R210 KOrganizer</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D24633?vs=67908&id=67971">https://phabricator.kde.org/D24633?vs=67908&id=67971</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24633">https://phabricator.kde.org/D24633</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/actionmanager.cpp<br />
src/data/korganizer.knsrc</div></div></div><br /><div><strong>To: </strong>winterz, mlaurent<br /><strong>Cc: </strong>kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>