<table><tr><td style="">krake requested changes to this revision.<br />krake added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22352">View Revision</a></tr></table><br /><div><div><p>Thanks!</p>
<p>One minor wish added :-)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22352#inline-128575">View Inline</a><span style="color: #4b4d51; font-weight: bold;">showcommand.cpp:105</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">mRaw</span> <span style="color: #aa2211">&&</span> <span class="n">item</span><span class="p">.</span><span class="n">hasPayload</span><span style="color: #aa2211"><</span><span class="n">KMime</span><span style="color: #aa2211">::</span><span class="n">Message</span><span style="color: #aa2211">::</span><span class="n">Ptr</span><span style="color: #aa2211">></span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">KMime</span><span style="color: #aa2211">::</span><span class="n">Message</span><span style="color: #aa2211">::</span><span class="n">Ptr</span> <span class="n">mail</span> <span style="color: #aa2211">=</span> <span class="n">item</span><span class="p">.</span><span class="n">payload</span><span style="color: #aa2211"><</span><span class="n">KMime</span><span style="color: #aa2211">::</span><span class="n">Message</span><span style="color: #aa2211">::</span><span class="n">Ptr</span><span style="color: #aa2211">></span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can I ask to move the mRaw check to else above?<br />
I.e. make it</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">} else if (mRaw) {
} else {
}</pre></div>
<p style="padding: 0; margin: 8px;">For non-emails the "not raw" should then do something like</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">std::cout << qPrintable(QString::fromUtf8(item.payloadData().constData());</pre></div>
<p style="padding: 0; margin: 8px;">Rational: if the local encoding is not UTF-8 then "raw" would still write the internal UTF-8 data (raw == not modified or recoded) but the "not raw" branch would recode to local8Bit</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R723 Akonadi CLI Client</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22352">https://phabricator.kde.org/D22352</a></div></div><br /><div><strong>To: </strong>dfaure, marten, krake<br /><strong>Cc: </strong>kde-pim<br /></div>