<table><tr><td style="">dfaure added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21444">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21444#inline-123518">View Inline</a><span style="color: #4b4d51; font-weight: bold;">knauss</span> wrote in <span style="color: #4b4d51; font-weight: bold;">antispamconfig.cpp:65</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Yes, I think so and I'm unsure what is the outcome of such a change. Can I check if we are in TestMode and disable this only when on testMode?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qputenv in the test and qgetenv here.<br />
Or make the test set an extern bool to true. See e.g. kio_resolve_local_urls in kio.</p>
<p style="padding: 0; margin: 8px;">Or make the test closer to the regular case ;-)<br />
In fact I'm wondering why this says setReadDefaults(true), i.e. ignore user settings. That's usually for "Revert to defaults" buttons.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R94 PIM: Message Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21444">https://phabricator.kde.org/D21444</a></div></div><br /><div><strong>To: </strong>knauss, KDE PIM, dfaure<br /><strong>Cc: </strong>dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss<br /></div>