<table><tr><td style="">barchiesi updated this revision to Diff 59908.<br />barchiesi added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21838">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">

<li class="remarkup-list-item">Deprecate Teamdrive fetch/create/modify/delete jobs.</li>

</ul>

<p>I added KGAPIDRIVE_DEPRECATED_EXPORT to the create/delete/modify/fetch jobs and afterwards all tests and the teamdrive example show warnings. Is that correct? Or should I delete tests/examples?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R477 KGAPI Library</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D21838?vs=59895&id=59908">https://phabricator.kde.org/D21838?vs=59895&id=59908</a></div></div><br /><div><strong>BRANCH</strong><div><div>drives</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21838">https://phabricator.kde.org/D21838</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/CMakeLists.txt<br />

autotests/drive/data/drives.json<br />

autotests/drive/data/drives_create_request.txt<br />

autotests/drive/data/drives_create_response.txt<br />

autotests/drive/data/drives_delete_request.txt<br />

autotests/drive/data/drives_fetch_request.txt<br />

autotests/drive/data/drives_fetch_response.txt<br />

autotests/drive/data/drives_hide_request.txt<br />

autotests/drive/data/drives_hide_response.txt<br />

autotests/drive/data/drives_modify_request.txt<br />

autotests/drive/data/drives_modify_response.txt<br />

autotests/drive/drivescreatejobtest.cpp<br />

autotests/drive/drivesdeletejobtest.cpp<br />

autotests/drive/drivesfetchjobtest.cpp<br />

autotests/drive/driveshidejobtest.cpp<br />

autotests/drive/drivesmodifyjobtest.cpp<br />

autotests/drive/drivessearchquerytest.cpp<br />

autotests/drive/drivetestutils.cpp<br />

autotests/drive/drivetestutils.h<br />

examples/CMakeLists.txt<br />

examples/drives/CMakeLists.txt<br />

examples/drives/main.cpp<br />

examples/drives/mainwindow.cpp<br />

examples/drives/mainwindow.h<br />

examples/drives/ui/main.ui<br />

src/core/types.h<br />

src/drive/CMakeLists.txt<br />

src/drive/drives.cpp<br />

src/drive/drives.h<br />

src/drive/drivescreatejob.cpp<br />

src/drive/drivescreatejob.h<br />

src/drive/drivesdeletejob.cpp<br />

src/drive/drivesdeletejob.h<br />

src/drive/driveservice.cpp<br />

src/drive/driveservice.h<br />

src/drive/drivesfetchjob.cpp<br />

src/drive/drivesfetchjob.h<br />

src/drive/driveshidejob.cpp<br />

src/drive/driveshidejob.h<br />

src/drive/drivesmodifyjob.cpp<br />

src/drive/drivesmodifyjob.h<br />

src/drive/drivessearchquery.cpp<br />

src/drive/drivessearchquery.h<br />

src/drive/teamdrivecreatejob.h<br />

src/drive/teamdrivedeletejob.h<br />

src/drive/teamdrivefetchjob.h<br />

src/drive/teamdrivemodifyjob.h</div></div></div><br /><div><strong>To: </strong>barchiesi<br /><strong>Cc: </strong>dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss<br /></div>