<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21650">View Revision</a></tr></table><br /><div><div><p>Good idea, this generally opens a new range of possibilities to simplify the code a bit, since the socket will now exist in user-specific directory (unlike until now it existed in <tt style="background: #ebebeb; font-size: 13px;">/tmp</tt> on Linux, which could possibly clash with other users if it were called only "akonadi", hence the username and random string) so the name can be deterministic without random strings.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21650#inline-121887">View Inline</a><span style="color: #4b4d51; font-weight: bold;">utils.cpp:104</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">link</span> <span style="color: #aa2211">=</span> <span class="n">StandardDirs</span><span style="color: #aa2211">::</span><span class="n">saveDir</span><span class="p">(</span><span style="color: #766510">"data"</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">'/'</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"socket-"</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">hostname</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QString</span> <span class="n">tmpl</span> <span style="color: #aa2211">=</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"<span class="bright">akonadi-"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">QString</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">fromLocal8Bit</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">pw_ent</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">pw_name</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">QLatin1String</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">".</span>XXXXXX"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QString</span> <span class="n">tmpl</span> <span style="color: #aa2211">=</span> <span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"XXXXXX"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Since on Linux you are now creating the directory in <tt style="background: #ebebeb; font-size: 13px;">/var/run/user/<uid>/</tt>, I'd very much prefer to keep <tt style="background: #ebebeb; font-size: 13px;">akonadi</tt> in the name...</p>

<p style="padding: 0; margin: 8px;">Actually, since you cannot have two same instances of Akonadi running at the same time, it should be perfectly fine to call the folder <tt style="background: #ebebeb; font-size: 13px;">akonadi</tt> for the default instance and <tt style="background: #ebebeb; font-size: 13px;">akonadi-<instancename></tt> when <tt style="background: #ebebeb; font-size: 13px;">Akonadi::Instance::hasIdentifier()</tt> is <tt style="background: #ebebeb; font-size: 13px;">true</tt>, no more random strings.</p>

<p style="padding: 0; margin: 8px;">This would make the directory deterministic for each instance, simplifying the code.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21650#inline-121888">View Inline</a><span style="color: #4b4d51; font-weight: bold;">utils.cpp:151</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">mkdtemp</span><span class="p">(</span><span class="n">directoryString</span><span class="p">.</span><span class="n">data</span><span class="p">()))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">qCCritical</span><span class="p">(</span><span class="n">AKONADISERVER_LOG</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Creating socket directory with template"</span> <span style="color: #aa2211"><<</span> <span class="n">directoryString</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"failed:"</span> <span style="color: #aa2211"><<</span> <span class="n">strerror</span><span class="p">(</span><span class="n">errno</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Once you change to the deterministic format, <tt style="background: #ebebeb; font-size: 13px;">mkdtemp </tt> can be switched to <tt style="background: #ebebeb; font-size: 13px;">QDir::mkpath()</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R165 Akonadi </div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21650">https://phabricator.kde.org/D21650</a></div></div><br /><div><strong>To: </strong>fazevedo, dfaure, dvratil<br /><strong>Cc: </strong>kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>