<table><tr><td style="">dfaure created this revision.<br />dfaure added a reviewer: dvratil.<br />dfaure requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21139">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Porting to unique_ptr would be complex here because each command<br />
goes through the following containers, between creation and usage+deletion:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">QList<FakeJobResponse *></li>
<li class="remarkup-list-item">QList<FakeAkonadiServerCommand *></li>
<li class="remarkup-list-item">QQueue<FakeAkonadiServerCommand *></li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><p>tagmodeltest with ASAN (but it has other leaks)</p></div></div><br /><div><strong>BRANCH</strong><div><div>itemretriever (branched from Applications/19.04)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21139">https://phabricator.kde.org/D21139</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/libs/fakeserverdata.cpp<br />
autotests/libs/fakeserverdata.h</div></div></div><br /><div><strong>To: </strong>dfaure, dvratil<br /><strong>Cc: </strong>kde-pim<br /></div>