<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21071">View Revision</a></tr></table><br /><div><div><p>The broken apidox links should probably be fixed and redirected to HTTPS as well.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21071#inline-118330">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:16</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">Similary</span><span class="p">,</span> <span style="color: #aa4000">this</span> <span class="n">library</span> <span class="n">does</span> <span class="n">not</span> <span class="n">deal</span> <span style="color: #aa4000">with</span> <span class="n">displaying</span> <span class="n">messages</span> <span class="n">or</span> <span class="n">advanced</span> <span class="n">composing</span><span class="p">,</span> <span style="color: #aa4000">for</span> <span class="n">those</span> <span class="n">there</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="n">are</span> <span class="n">the</span> <span class="p">[</span><span class="n">messageviewer</span><span class="p">](</span><span class="n">http</span><span class="p">:</span><span style="color: #74777d">//api.kde.org/4.x-api/kdepim-apidocs/messageviewer/html/index.html)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="n">and</span> <span class="n">the</span> <span class="p">[</span><span class="n">messagecomposer</span><span class="p">](</span><span class="n">http</span><span class="p">:</span><span style="color: #74777d">//websvn.kde.org/trunk/KDE/kdepim/messagecomposer/")</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">and</span> <span class="n">the</span> <span class="p">[</span><span class="n">messagecomposer</span><span class="p">](</span><span class="n">http<span class="bright">s</span></span><span class="p">:</span><span style="color: #74777d">//websvn.kde.org/trunk/KDE/kdepim/messagecomposer/")</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Also doesn't work.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21071#inline-118329">View Inline</a><span style="color: #4b4d51; font-weight: bold;">README.md:837</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">Security</span> <span class="n">multiparts</span> <span class="n">are</span> <span class="n">not</span> <span class="n">supported</span> <span class="n">by</span> <span class="n">KMime</span><span class="p">.</span> <span class="n">However</span><span class="p">,</span> <span class="n">it</span> <span style="color: #aa4000">is</span> <span class="n">possible</span> <span style="color: #aa4000">for</span> <span class="n">applications</span> <span class="n">to</span> <span class="n">use</span> <span class="n">KMime</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="n">when</span> <span class="n">providing</span> <span class="n">support</span> <span style="color: #aa4000">for</span> <span class="n">crypto</span> <span class="n">messages</span><span class="p">.</span> <span class="n">For</span> <span class="n">example</span><span class="p">,</span> <span class="n">the</span> <span class="p">[</span><span class="n">messageviewer</span><span class="p">](</span><span class="n">http</span><span class="p">:</span><span style="color: #74777d">//api.kde.org/4.x-api/kdepim-apidocs/messageviewer/html/index.html)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="n">component</span> <span style="color: #aa4000">in</span> <span class="n">KDEPIM</span> <span class="n">supports</span> <span class="n">signed</span> <span class="n">and</span> <span class="n">encrypted</span> <span class="n">MIME</span> <span class="n">parts</span><span class="p">,</span> <span class="n">and</span> <span class="n">the</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This link doesn't work even in HTTP version :(</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R180 PIM: KMime</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21071">https://phabricator.kde.org/D21071</a></div></div><br /><div><strong>To: </strong>vkrause, dvratil<br /><strong>Cc: </strong>dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss<br /></div>