<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20789">View Revision</a></tr></table><br /><div><div><p>According to <a href="https://developers.google.com/drive/api/v3/reference/files/get" class="remarkup-link" target="_blank" rel="noreferrer">https://developers.google.com/drive/api/v3/reference/files/get</a> the <tt style="background: #ebebeb; font-size: 13px;">supportsTeamDrives</tt> parameter is deprecated and should not be used. We should be setting <tt style="background: #ebebeb; font-size: 13px;">supportsAllDrives</tt> and <tt style="background: #ebebeb; font-size: 13px;">includeItemsFromAllDrives</tt>  and we should be setting them to <tt style="background: #ebebeb; font-size: 13px;">true</tt> unconditionally since we now support Team Drives - in 2020 GDrive will start ignoring those parameters and will always list contents from Team drives, too, so effectively setting them to <tt style="background: #ebebeb; font-size: 13px;">false</tt> in KGAPI would look like a bug.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R477 KGAPI Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20789">https://phabricator.kde.org/D20789</a></div></div><br /><div><strong>To: </strong>barchiesi, dvratil<br /><strong>Cc: </strong>kde-pim, LibKGAPI, barchiesi, gennad, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>