<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20363">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20363#inline-115156">View Inline</a><span style="color: #4b4d51; font-weight: bold;">collectionschedulertest.cpp:52</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">qint64</span> <span style="color: #a0a000">collectionId</span> <span class="p">:</span> <span class="p">{</span><span style="color: #601200">1</span><span class="p">,</span> <span style="color: #601200">2</span><span class="p">,</span> <span style="color: #601200">3</span><span class="p">,</span> <span style="color: #601200">5</span><span class="p">,</span> <span style="color: #601200">6</span><span class="p">,</span> <span style="color: #601200">7</span><span class="p">})</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">QVERIFY</span><span class="p">(</span><span class="n">sched</span><span class="p">.</span><span class="n">nextScheduledTime</span><span class="p">(</span><span class="n">collectionId</span><span class="p">)</span> <span style="color: #aa2211">></span> <span class="n">now</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span style="color: #601200"><span class="bright">4</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">60</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">QVERIFY</span><span class="p">(</span><span class="n">sched</span><span class="p">.</span><span class="n">nextScheduledTime</span><span class="p">(</span><span class="n">collectionId</span><span class="p">)</span> <span style="color: #aa2211"><</span> <span class="n">now</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span style="color: #601200"><span class="bright">6</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">60</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">QVERIFY</span><span class="p">(</span><span class="n">sched</span><span class="p">.</span><span class="n">nextScheduledTime</span><span class="p">(</span><span class="n">collectionId</span><span class="p">)</span> <span style="color: #aa2211">></span> <span class="n">now</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span class="n"><span class="bright">std</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">chrono</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">minutes</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">4</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">QVERIFY</span><span class="p">(</span><span class="n">sched</span><span class="p">.</span><span class="n">nextScheduledTime</span><span class="p">(</span><span class="n">collectionId</span><span class="p">)</span> <span style="color: #aa2211"><</span> <span class="n">now</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span class="n"><span class="bright">std</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">chrono</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">minutes</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">6</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Add <tt style="background: #ebebeb; font-size: 13px;">using namespace std::chrono_literals</tt> to the top, then you can use <tt style="background: #ebebeb; font-size: 13px;">4m</tt> instead of having to spell out the whole type (also elsewhere in the code).</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20363">https://phabricator.kde.org/D20363</a></div></div><br /><div><strong>To: </strong>dfaure, dvratil<br /><strong>Cc: </strong>pino, kde-pim<br /></div>