<table><tr><td style="">winterz created this revision.<br />winterz added reviewers: dvratil, mlaurent.<br />Herald added a project: KDE PIM.<br />Herald added a subscriber: kde-pim.<br />winterz requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20091">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Don't compile in the nicknamewidget since it isn't used and doesn't have the proper linkage.</p>

<p>On Windows we see:<br />
c:\kf5\_\33199f3e\relwithdebinfo-18.12.2\src\contact-editor\editor\generalinfoeditor\tests\generalinfoeditortest_autogen\W7L2QYDORH/moc_nicknamewidget.cpp(<br />
58): warning C4273: 'ContactEditor::NicknameWidget::qt_static_metacall': inconsistent dll linkage<br />
c:\kf5\_\33199f3e\relwithdebinfo-18.12.2\src\contact-editor\editor\generalinfoeditor\tests\generalinfoeditortest_autogen\w7l2qydorh\../../../../../../../..<br />
/akonadi-contacts-18.12.2/src/contact-editor/editor/generalinfoeditor/nicknamewidget.h(35): note: see previous definition of 'qt_static_metacall'<br />
c:\kf5\_\33199f3e\relwithdebinfo-18.12.2\src\contact-editor\editor\generalinfoeditor\tests\generalinfoeditortest_autogen\W7L2QYDORH/moc_nicknamewidget.cpp(<br />
65): warning C4273: 'staticMetaObject': inconsistent dll linkage<br />
c:\kf5\_\33199f3e\relwithdebinfo-18.12.2\src\contact-editor\editor\generalinfoeditor\tests\generalinfoeditortest_autogen\w7l2qydorh\../../../../../../../..<br />
/akonadi-contacts-18.12.2/src/contact-editor/editor/generalinfoeditor/nicknamewidget.h(35): note: see previous definition of 'public: static QMetaObject co<br />
nst ContactEditor::NicknameWidget::staticMetaObject'<br />
c:\kf5\_\33199f3e\relwithdebinfo-18.12.2\src\contact-editor\editor\generalinfoeditor\tests\generalinfoeditortest_autogen\W7L2QYDORH/moc_nicknamewidget.cpp(<br />
65): error C2491: 'ContactEditor::NicknameWidget::staticMetaObject': definition of dllimport static data member not allowed<br />
c:\kf5\_\33199f3e\relwithdebinfo-18.12.2\src\contact-editor\editor\generalinfoeditor\tests\generalinfoeditortest_autogen\W7L2QYDORH/moc_nicknamewidget.cpp(<br />
76): warning C4273: 'ContactEditor::NicknameWidget::metaObject': inconsistent dll linkage</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>links ok on Windows<br />
links ok on linux</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R459 Akonadi Contacts</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20091">https://phabricator.kde.org/D20091</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/contact-editor/editor/generalinfoeditor/tests/CMakeLists.txt</div></div></div><br /><div><strong>To: </strong>winterz, dvratil, mlaurent<br /><strong>Cc: </strong>kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>