<table><tr><td style="">marten created this revision.<br />marten added a reviewer: KDE PIM.<br />Herald added a project: KDE PIM.<br />Herald added a subscriber: kde-pim.<br />marten requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20075">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Compiling current messagelib source without BUILD_TESTING defined produces the error:</p>

<p>[ 73%] Linking CXX shared library ../../bin/libKF5MessageComposer.so<br />
CMakeFiles/KF5MessageComposer.dir/attachment/attachmentcontrollerbase.cpp.o: In function `MessageComposer::AttachmentControllerBase::Private::updateJobResult(KJob*)':<br />
messagelib/messagecomposer/src/attachment/attachmentcontrollerbase.cpp:292: undefined reference to `typeinfo for MessageCore::AttachmentUpdateJob'<br />
messagelib/messagecomposer/src/attachment/attachmentcontrollerbase.cpp:294: undefined reference to `MessageCore::AttachmentUpdateJob::originalPart() const'<br />
messagelib/messagecomposer/src/attachment/attachmentcontrollerbase.cpp:295: undefined reference to `MessageCore::AttachmentUpdateJob::updatedPart() const'<br />
CMakeFiles/KF5MessageComposer.dir/attachment/attachmentcontrollerbase.cpp.o: In function `MessageComposer::AttachmentControllerBase::Private::reloadAttachment()':<br />
messagelib/messagecomposer/src/attachment/attachmentcontrollerbase.cpp:279: undefined reference to `MessageCore::AttachmentUpdateJob::AttachmentUpdateJob(QSharedPointer<MessageCore::AttachmentPart> const&, QObject*)'<br />
collect2: error: ld returned 1 exit status<br />
make[2]: <strong>* [messagecomposer/src/CMakeFiles/KF5MessageComposer.dir/build.make:1252: bin/libKF5MessageComposer.so.5.10.90] Error 1<br />
make[1]: </strong>* [CMakeFiles/Makefile2:819: messagecomposer/src/CMakeFiles/KF5MessageComposer.dir/all] Error 2<br />
make: *** [Makefile:130: all] Error 2</p>

<p>This appears to be because AttachmentUpdateJob is only exported with MESSAGECORE_TESTS_EXPORT as a result of commit <a href="https://phabricator.kde.org/R94:7f6c2bdfca1d82c893d770eef7d7047fbdcf0e8d" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">7f6c2bdfc</a>, but it is required by messagecomposer.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>With this change, messagelib builds correctly with BUILD_TESTING not defined.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R94 PIM: Message Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20075">https://phabricator.kde.org/D20075</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>messagecore/src/attachment/attachmentupdatejob.h</div></div></div><br /><div><strong>To: </strong>marten, KDE PIM<br /><strong>Cc: </strong>kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>