<table><tr><td style="">cgiboudeaux accepted this revision.<br />cgiboudeaux added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19892">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19892#inline-111845">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CodingStyle.txt:5</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">The rules and all the scripts are free for download and comments at:
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  http://techbase.kde.org/Policies/Kdepim_Coding_Style
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  http<span class="bright">s</span>://techbase.kde.org/Policies/Kdepim_Coding_Style
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><a href="https://community.kde.org/Policies/Kdepim_Coding_Style" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Policies/Kdepim_Coding_Style</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19892#inline-111846">View Inline</a><span style="color: #4b4d51; font-weight: bold;">client_libraries.md:20</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">-</span> <span class="p"><</span><span class="n">a</span> <span class="n">href</span><span class="p">=</span><span style="color: #766510">"http://my.cdash.org/index.php?project=kdepimlibs"</span><span class="p">></span><span class="n">CDash</span><span class="p"></</span><span class="n">a</span><span class="p">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">-</span> <span class="p"><</span><span class="n">a</span> <span class="n">href</span><span class="p">=</span><span style="color: #766510">"http<span class="bright">s</span>://my.cdash.org/index.php?project=kdepimlibs"</span><span class="p">></span><span class="n">CDash</span><span class="p"></</span><span class="n">a</span><span class="p">></span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">-</span> <span class="p"><</span><span class="n">a</span> <span class="n">href</span><span class="p">=</span><span style="color: #766510">"https://bugs.kde.org/buglist.cgi?query_format=advanced&product=Akonadi&component=libakonadi&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED"</span><span class="p">></span><span class="n">Bugtracker</span><span class="p"></</span><span class="n">a</span><span class="p">></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we don't use CDash anymore</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19892#inline-111847">View Inline</a><span style="color: #4b4d51; font-weight: bold;">client_libraries.md:21</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">-</span> <span class="p"><</span><span class="n">a</span> <span class="n">href</span><span class="p">=</span><span style="color: #766510">"http://my.cdash.org/index.php?project=kdepimlibs"</span><span class="p">></span><span class="n">CDash</span><span class="p"></</span><span class="n">a</span><span class="p">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">-</span> <span class="p"><</span><span class="n">a</span> <span class="n">href</span><span class="p">=</span><span style="color: #766510">"http<span class="bright">s</span>://my.cdash.org/index.php?project=kdepimlibs"</span><span class="p">></span><span class="n">CDash</span><span class="p"></</span><span class="n">a</span><span class="p">></span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">-</span> <span class="p"><</span><span class="n">a</span> <span class="n">href</span><span class="p">=</span><span style="color: #766510">"https://bugs.kde.org/buglist.cgi?query_format=advanced&product=Akonadi&component=libakonadi&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED"</span><span class="p">></span><span class="n">Bugtracker</span><span class="p"></</span><span class="n">a</span><span class="p">></span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">//--></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">shall be <a href="https://bugs.kde.org/buglist.cgi?query_format=advanced&product=Akonadi&component=libakonadi&bug_status=REPORTED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_status=REOPENED" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/buglist.cgi?query_format=advanced&product=Akonadi&component=libakonadi&bug_status=REPORTED&bug_status=CONFIRMED&bug_status=ASSIGNED&bug_status=REOPENED</a> nowadays</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R165 Akonadi </div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19892">https://phabricator.kde.org/D19892</a></div></div><br /><div><strong>To: </strong>vkrause, cgiboudeaux<br /><strong>Cc: </strong>cgiboudeaux, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>