<table><tr><td style="">kfunk added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17563">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17563#inline-96424">View Inline</a><span style="color: #4b4d51; font-weight: bold;">marten</span> wrote in <span style="color: #4b4d51; font-weight: bold;">articleviewerwebengine.cpp:68</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Is there any point in using 'override' on destructors? There is no function signature to trigger the usual warning case (derived class defines a function with a different signature, so not really replacing the base class virtual), so there is no way a destructor can be written to not override. The compiler doesn't consider destructors in its override warning.</p>
<p style="padding: 0; margin: 8px;">The only way in which 'override' would be useful on a destructor would be to give an error if the base class destructor was not declared virtual, but with a correctly written base class this should not arise.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Sorry for getting more off-topic, but /me wants to clarify this:</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">The only way in which 'override' would be useful on a destructor would be to give an error if the base class destructor was not declared virtual, (...)</p></blockquote>
<p style="padding: 0; margin: 8px;">Right, and why not protect against this? I think adding an <tt style="background: #ebebeb; font-size: 13px;">override</tt> to dtors makes a lot of sense. Especially if you think of <tt style="background: #ebebeb; font-size: 13px;">override</tt> as of: "I expect there to exist a base class version of this function which is declared virtual".</p>
<p style="padding: 0; margin: 8px;">Also see discussion on qt-development: <a href="https://lists.qt-project.org/pipermail/development/2018-August/033437.html" class="remarkup-link" target="_blank" rel="noreferrer">https://lists.qt-project.org/pipermail/development/2018-August/033437.html</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R201 Akregator</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17563">https://phabricator.kde.org/D17563</a></div></div><br /><div><strong>To: </strong>amantia, KDE PIM (Applications 18.12 (master)), mlaurent<br /><strong>Cc: </strong>marten, asturmlechner, kfunk, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>