<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16556">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16556#inline-90242">View Inline</a><span style="color: #4b4d51; font-weight: bold;">entitytreemodeltest.cpp:131</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">FakeMonitor</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="n">fakeMonitor</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">FakeMonitor</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span class="n">fakeMonitor</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">FakeMonitor</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><rant>I'm starting to dislike the <tt style="background: #ebebeb; font-size: 13px;">QObject</tt>'s "parent" more and more...here <tt style="background: #ebebeb; font-size: 13px;">this</tt> becomes the owner of the object, yet semantically the ownership should be in <tt style="background: #ebebeb; font-size: 13px;">FakeServerData</tt>. The <tt style="background: #ebebeb; font-size: 13px;">const</tt>ness that you added here makes it even more confusing, as it hides the fact that there's ownership transfer...ideally this would be a <tt style="background: #ebebeb; font-size: 13px;">std::unique_ptr</tt> that would be <tt style="background: #ebebeb; font-size: 13px;">std::move()</tt>d into <tt style="background: #ebebeb; font-size: 13px;">FakeServerData</tt>, clearly expressing the ownership and its transfer.</rant></p>
<p style="padding: 0; margin: 8px;">(You don't have to change this, fixing ownership expression in the codebase is way out-of-scope, especially for tests)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16556#inline-90243">View Inline</a><span style="color: #4b4d51; font-weight: bold;">entitytreemodeltest.cpp:179</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">FakeMonitor</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="n">fakeMonitor</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">FakeMonitor<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #aa4000">this<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span class="n">fakeMonitor</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">FakeMonitor<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">{</span></span><span style="color: #aa4000">this<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">}</span>;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You should use the uniform initialization...uniformly :-) So everywhere, or nowhere (except where required to solve most vexing parse - preferred), just don't use it randomly, please.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R165 Akonadi </div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16556">https://phabricator.kde.org/D16556</a></div></div><br /><div><strong>To: </strong>dkurz, KDE PIM, dvratil<br /><strong>Cc: </strong>dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss<br /></div>