<table><tr><td style="">ognarb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16601">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D16601#352479" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D16601#352479</a>, <a href="https://phabricator.kde.org/p/dkurz/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dkurz</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Replacing <tt style="background: #ebebeb; font-size: 13px;">Q_FOREACH</tt> with range-based <tt style="background: #ebebeb; font-size: 13px;">for</tt> actually might change performance, in case the data structure detaches. Basically, Q_FOREACH creates a const copy of the container and iterates over that, so no detaching happens.</p>
<p>Since you did not use a single <tt style="background: #ebebeb; font-size: 13px;">qAsConst</tt>, you might be interested in <a href="https://www.kdab.com/goodbye-q_foreach/" class="remarkup-link" target="_blank" rel="noreferrer">https://www.kdab.com/goodbye-q_foreach/</a>. OTOH, not using it is sometimes correct, e.g. if you iterate over an already const container or if you are extra careful that no detaching happens in the body (which might change in the future, though).</p></div>
</blockquote>
<p>Interesting I will make change :D</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R76 PIM: Event Views</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16601">https://phabricator.kde.org/D16601</a></div></div><br /><div><strong>To: </strong>ognarb, KDE PIM<br /><strong>Cc: </strong>dkurz, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>