<table><tr><td style="">dvratil added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14127">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14127#inline-74298">View Inline</a><span style="color: #4b4d51; font-weight: bold;">address.cpp:655</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// we search a map file for translations from country names to</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// iso codes, storing caching things in a QMap for faster future</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// access.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">s/QMap/QHash/</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14127#inline-74299">View Inline</a><span style="color: #4b4d51; font-weight: bold;">address.cpp:672</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span class="bright"></span><span class="n"><span class="bright">sISOMap</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">insert</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">cname</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="n">countryInfo</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">]);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span class="bright"></span><span style="color: #aa4000"><span class="bright">return</span></span><span class="bright"> </span><span class="n">country<span class="bright">Info</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"></span><span class="p"><span class="bright">]</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span class="n"><span class="bright">iso</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span> <span class="n">countryInfo</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">]<span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">toString</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="bright"></span><span class="n"><span class="bright">sIsoCache</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="n">country<span class="bright">ToIso</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">insert</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">cname</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">iso</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">return</span> <span class="n">iso</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Would it make sense to also insert the strings to the <tt style="background: #ebebeb; font-size: 13px;">isoToCountry</tt> hash table to benefit QString's explicit sharing (and vice-verase in <tt style="background: #ebebeb; font-size: 13px;">ISOToCountry()</tt>), or is it unlikely any code would benefit from this?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R174 PIM: KContacts</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14127">https://phabricator.kde.org/D14127</a></div></div><br /><div><strong>To: </strong>vkrause<br /><strong>Cc: </strong>dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss<br /></div>