<table><tr><td style="">dfaure created this revision.<br />dfaure added reviewers: mlaurent, dvratil.<br />Restricted Application added a project: KDE PIM.<br />dfaure requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12303">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>For many years I would randomly see one of my email folders become<br />
unselectable, often my inbox, for no apparent reason. And if it was<br />
actually selected when this happened, then switching to another folder<br />
would select both (not being able to unselect the now-unselectable one),<br />
showing the merged view in the messagelist.<br />
Only apparent solution was a kmail restart.<br />
I finally found what triggered all this: Ctrl+X !<br />
Cut collections were marked as selectable, but not enabled, which<br />
effectively made them unselectable.</p>
<p>New solution: leaving flags untouched in the model, and simply changing<br />
the text color in the delegate, for cut collections.<br />
This makes cut collections still fully work, just like you can fully<br />
interact with cut files in a file manager.</p>
<p>I wonder if we want to do the same with cut items, but I'm not sure where<br />
the delegate(s) are, and how to catch them all. The risk of accidentally<br />
cutting is much lower with items anyway (Ctrl+Alt+X).<br />
Also, this code came from the fix for bug 213466, which was about items<br />
in the first place (not collections).</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>click on email folder, Ctrl+X. Try it, it's fun.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R165 Akonadi </div></div></div><br /><div><strong>BRANCH</strong><div><div>Applications/18.04</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12303">https://phabricator.kde.org/D12303</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/core/models/entitytreemodel.cpp<br />
src/core/models/entitytreemodel.h<br />
src/widgets/collectionstatisticsdelegate.cpp</div></div></div><br /><div><strong>To: </strong>dfaure, mlaurent, dvratil<br /><strong>Cc: </strong>KDE PIM, dvasin, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>