<table><tr><td style="">joselema added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11508">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D11508#230506" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11508#230506</a>, <a href="https://phabricator.kde.org/p/mlaurent/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mlaurent</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>"... because the KDE CI is like Superman, with X-Ray vision. A god made of bits. And of course if a problem isn't catched by the KDE CI, that problem simply doesn't exist."<br />
We can try all wierd configuration for sure but with KDE CI we use standard configuration.</p>
<p>So after that ubuntu likes wierd configuration it's your choice :)</p></div>
</blockquote>
<p>Well, it's not a "weird configuration", it's just a headers check which reveals a problem with the KDE code which the KDE CI, right now, doesn't detect. Just for the record the headers check is meant to reveal problems in the packaging, however, as a side effect, sometimes it reveals problems in the KDE code like in this case.</p>
<p>To fix this problem for Kubuntu, we simply commented out temporarily the headers check. But please note that the universe is bigger than KDE and Ubuntu; this test is inherited from Debian, so consider the following hypothetical situation:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">The Debian developer packages a newer version of messagelib.</li>
<li class="remarkup-list-item">The headers test fail.</li>
<li class="remarkup-list-item">One possible solution is patching the code, if the Debian developer patches the code, the patch may be right or wrong (like the first version of the patch I proposed)</li>
<li class="remarkup-list-item">Let's supose the patch is wrong, the Debian developer may or may not have time to send the patch here for review.</li>
<li class="remarkup-list-item">I wouldn't be surprised if the wrong patch goes unnoticed to the Kubuntu and KDE Neon packaging via merges.</li>
</ol>
<p>It's in our best interest to keep to a bare minimum the distribution patching, right? So what's the right solution here? Commenting out the headers check in Kubuntu like we did? Well, I think it's a lot better to be a step ahead and fix the problem in the KDE scope (like you just did this morning) rather than leaving loose ends which may result in an exccesive/wrong distribution patching.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>For me the second patch seems more logical.</p>
<p>Perhaps you can test it.<br />
Indeed we don't need to install it<br />
so we don't need your first patch where you want to install not necessary headers.</p></blockquote>
<p>That's great to know, I'm going to update the patch then.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I removed some bad include in 18.04 so perhaps it will help you in your wierd config</p></blockquote>
<p>It's not a "weird config"...</p>
<p>Anyway, I have tested a modified 17.12.3 package with the following commits you did in master:<br />
<a href="https://cgit.kde.org/messagelib.git/commit/?id=feda4e33e9e935384fc322878d8da58e1f08e562" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/messagelib.git/commit/?id=feda4e33e9e935384fc322878d8da58e1f08e562</a><br />
<a href="https://cgit.kde.org/messagelib.git/commit/?id=28e8731a152b98f8f80c896c6b389748d5fdee43" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/messagelib.git/commit/?id=28e8731a152b98f8f80c896c6b389748d5fdee43</a><br />
<a href="https://cgit.kde.org/messagelib.git/commit/?id=e068f81e9a6176309301eed7765aa54b2ef120dc" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/messagelib.git/commit/?id=e068f81e9a6176309301eed7765aa54b2ef120dc</a><br />
<a href="https://cgit.kde.org/messagelib.git/commit/?id=1d9e28e3aa8bd1d7ad1b7b56720c436cd2dce8b9" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/messagelib.git/commit/?id=1d9e28e3aa8bd1d7ad1b7b56720c436cd2dce8b9</a></p>
<p>That indeed fixes the problem, avoiding to install extra headers because you did something similar to the first patch, but removing <core/sortorder.h> from widgetbase.h which removes the need to install other extra headers in the pack, and thus, the main mistake from the first patch. Thank you for fixing it.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R94 PIM: Message Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11508">https://phabricator.kde.org/D11508</a></div></div><br /><div><strong>To: </strong>joselema, KDE PIM, KDE PIM: KMail, mlaurent<br /><strong>Cc: </strong>mlaurent, joselema, rikmills, dvasin, hrouis, ach, winterz, vkrause, knauss, dvratil<br /></div>