<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130249/">https://git.reviewboard.kde.org/r/130249/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Reviewboad is closed (use phabricator for it)
and you didn't put patch for reviewing.
you added a mail text... So we can"t review it.</p></pre>
<br />
<p>- Laurent Montel</p>
<br />
<p>On mars 20th, 2018, 4:51 après-midi UTC, Tobias Junghans wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDEPIM and Laurent Montel.</div>
<div>By Tobias Junghans.</div>
<p style="color: grey;"><em>Updated mars 20, 2018, 4:51 après-midi</em></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This implements basic support for setting the TLS certificate request option (LDAP_OPT_X_TLS_REQUIRE_CERT) as well as a dedicated certificate
file for checking server certificate (LDAP_OPT_X_TLS_CACERTFILE).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">TLS connection to LDAP server with self-signed certificate</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">scenario a) none of the new options set -> connection fails due to missing certificate to check against</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">scenario b) use LdapServer::TLSReqCertNever which makes the connection succeed</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">scenario c) use LdapServer::TLSReqCertHard and set tlsCACertFile which makes the connection succeed</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2018/03/20/69f4abb3-fa32-47da-90c6-a133314aaa6e__0001-Add-support-for-TLS-CA-certificate-handling.patch">0001-Add-support-for-TLS-CA-certificate-handling.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>