<table><tr><td style="">knauss added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10011" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p><a href="https://phabricator.kde.org/p/cgiboudeaux/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@cgiboudeaux</a>: did you checked on Windows? Is the whole WIN32 block is still needed, or can it removed completly?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10011#inline-45962" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cgiboudeaux</span> wrote in <span style="color: #4b4d51; font-weight: bold;">FindLibIcal.cmake:4</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Please change it back to LibIcal_INCLUDE_DIRS. We're following the CMake policies and coding style recommendations</p>
<p style="padding: 0; margin: 8px;">Xxx_INCLUDE_DIRS</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">The final set of include directories listed in one variable for use by client code. This should not be a cache entry.</pre></div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">mmh i changed it because pkgconfig returns XXX_INCLUDEDIR and I thought so this is the more "stadardized" name.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10011#inline-45965" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cgiboudeaux</span> wrote in <span style="color: #4b4d51; font-weight: bold;">FindLibIcal.cmake:18-20</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">use the QUIET keyword for both lines</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">for the first I can understand, beause we don't want PkgConfig found line shown.<br />
But why QUIT for the second line?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10011#inline-46071" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindLibIcal.cmake:23</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">if</span><span class="p">(</span><span style="color: #766510">WIN32</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">file</span><span class="p">(</span><span style="color: #766510">TO_CMAKE_PATH</span> <span style="color: #766510">"$ENV{PROGRAMFILES}"</span> <span style="color: #766510">_program_FILES_DIR</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if we don't if/endif the pkgconfig call, we can modify to <br />
if(NOT LibIcal_FOUND)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R172 KCalendar Core</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10011" rel="noreferrer">https://phabricator.kde.org/D10011</a></div></div><br /><div><strong>To: </strong>knauss, KDE PIM, winterz<br /><strong>Cc: </strong>cgiboudeaux, dvasin, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>