<table><tr><td style="">cgiboudeaux added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10011" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10011#inline-46119" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindLibIcal.cmake:19</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">  </span><span style="color: #304a96"><span class="bright">file</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">TO_CMAKE_PATH</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"$ENV{PROGRAMFILES}"</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">_program_FILES_DIR</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">pkg_check_modules</span><span class="p">(</span><span style="color: #766510">LibIcal</span> <span style="color: #766510">libical>=</span><span style="color: #aa2211">${</span><span style="color: #001294">LibIcal_FIND_VERSION</span><span style="color: #aa2211">}</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">still missing the QUIET keyword.<br />
Please also rename LibIcal to avoid confusion between the pkgconfig vars and the CMake ones (pick eg 'PC_LibIcal' )</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10011#inline-46121" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindLibIcal.cmake:21</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">if</span><span class="p">(</span><span style="color: #766510">NOT</span> <span style="color: #766510">LibIcal_INCLUDE_DIRS</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">   <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">LibIcal_INCLUDE_DIRS</span> <span style="color: #aa2211">${</span><span style="color: #001294">LibIcal_INCLUDEDIR</span><span style="color: #aa2211">}</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not needed here, it doesn't exist yet</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10011#inline-46120" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindLibIcal.cmake:22</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">if</span><span class="p">(</span><span style="color: #766510">NOT</span> <span style="color: #766510">LibIcal_INCLUDE_DIRS</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">   <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">LibIcal_INCLUDE_DIRS</span> <span style="color: #aa2211">${</span><span style="color: #001294">LibIcal_INCLUDEDIR</span><span style="color: #aa2211">}</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">endif</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it's not the right place for that. See below</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10011#inline-46122" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindLibIcal.cmake:23</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">   <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">LibIcal_INCLUDE_DIRS</span> <span style="color: #aa2211">${</span><span style="color: #001294">LibIcal_INCLUDEDIR</span><span style="color: #aa2211">}</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">endif</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Remove</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10011#inline-46124" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindLibIcal.cmake:37</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">     <span style="color: #766510">NAMES</span> <span style="color: #766510">libical/ical.h</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">     <span style="color: #766510">HINTS</span> <span style="color: #aa2211">${</span><span style="color: #001294">libical_root</span><span style="color: #aa2211">}</span><span style="color: #766510">/include</span> <span style="color: #aa2211">${</span><span style="color: #001294">_program_FILES_DIR</span><span style="color: #aa2211">}</span><span style="color: #766510">/libical/include</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">   <span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">+ ${PC_LibIcal_INCLUDEDIR}</p>

<p style="padding: 0; margin: 8px;">That's where we use the pkgconfig result</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10011#inline-46125" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindLibIcal.cmake:43-44</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">     <span style="color: #766510">HINTS</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">       <span style="color: #aa2211">${</span><span style="color: #001294">libical_root</span><span style="color: #aa2211">}</span><span style="color: #766510">/lib64</span> <span style="color: #aa2211">${</span><span style="color: #001294">_program_FILES_DIR</span><span style="color: #aa2211">}</span><span style="color: #766510">/libical/lib64</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">       <span style="color: #aa2211">${</span><span style="color: #001294">libical_root</span><span style="color: #aa2211">}</span><span style="color: #766510">/lib</span> <span style="color: #aa2211">${</span><span style="color: #001294">_program_FILES_DIR</span><span style="color: #aa2211">}</span><span style="color: #766510">/libical/lib</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">   <span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">+ ${PC_LibIcal_LIBDIR}</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10011#inline-46126" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindLibIcal.cmake:50-51</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">     <span style="color: #766510">HINTS</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">       <span style="color: #aa2211">${</span><span style="color: #001294">libical_root</span><span style="color: #aa2211">}</span><span style="color: #766510">/lib64</span> <span style="color: #aa2211">${</span><span style="color: #001294">_program_FILES_DIR</span><span style="color: #aa2211">}</span><span style="color: #766510">/libical/lib64</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">       <span style="color: #aa2211">${</span><span style="color: #001294">libical_root</span><span style="color: #aa2211">}</span><span style="color: #766510">/lib</span> <span style="color: #aa2211">${</span><span style="color: #001294">_program_FILES_DIR</span><span style="color: #aa2211">}</span><span style="color: #766510">/libical/lib</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">   <span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">+ ${PC_LibIcal_LIBDIR}</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R172 KCalendar Core</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10011" rel="noreferrer">https://phabricator.kde.org/D10011</a></div></div><br /><div><strong>To: </strong>knauss, KDE PIM, winterz<br /><strong>Cc: </strong>cgiboudeaux, dvasin, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>