<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125726/">https://git.reviewboard.kde.org/r/125726/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ping ? this wasn't pushed.</pre>
<br />
<p>- Christophe Giboudeaux</p>
<br />
<p>On octobre 20th, 2015, 2:56 après-midi UTC, Daniel Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDEPIM and Frank Osterfeld.</div>
<div>By Daniel Vrátil.</div>
<p style="color: grey;"><em>Updated oct. 20, 2015, 2:56 après-midi</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
syndication
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Those were just convenience classes for retrieving the feeds via KIO. Removing them allows us to drop the KIO dependency completely.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I only preserved discoverFeedURL(), which is non-trivial, the rest can be easily handled by applications.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adapted Akregator, everything seems to work.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e833c1b)</span></li>
<li>src/syndication/CMakeLists.txt <span style="color: grey">(74dd9b0)</span></li>
<li>src/syndication/dataretriever.h <span style="color: grey">(648c824)</span></li>
<li>src/syndication/dataretriever.cpp <span style="color: grey">(da53496)</span></li>
<li>src/syndication/global.h <span style="color: grey">(78f8566)</span></li>
<li>src/syndication/global.cpp <span style="color: grey">(79aefad)</span></li>
<li>src/syndication/loader.h <span style="color: grey">(ba70af0)</span></li>
<li>src/syndication/loader.cpp <span style="color: grey">(c77bf5f)</span></li>
<li>src/syndication/syndication.h <span style="color: grey">(d0e1094)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(173b7fe)</span></li>
<li>tests/testloader.h <span style="color: grey">(afaa6c1)</span></li>
<li>tests/testloader.cpp <span style="color: grey">(22ade3d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125726/diff/1/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>