<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121096/">https://git.reviewboard.kde.org/r/121096/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDEPIM.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><em>Updated nov. 13, 2017, 4:40 après-midi</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
kdepim-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch does as said in the summary. Rationale is to avoid log pollution, storing potentially sensitive data in unexpected locations and waste of CPU cycles.
First impressions are that disabling debug output (which is now under kdebugdialog control) does indeed make KMail considerably "snappier" (at least when combined with akonadi built with -DQT_NO_DEBUG_OUTPUT).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This also makes kdepim-runtime adhere more closely to KDE debugging output guidelines.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ubuntu 14.04 with kdelibs 4.14.2 .</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>agents/newmailnotifier/newmailnotifiershowmessagejob.cpp <span style="color: grey">(cbbcbed)</span></li>
<li>qml/kde/kdeintegrationplugin.cpp <span style="color: grey">(c1360b4)</span></li>
<li>qml/kde/tests/qml_moves/dynamictreemodel.cpp <span style="color: grey">(5537bb7)</span></li>
<li>qml/kde/tests/qml_moves/mainwindow.cpp <span style="color: grey">(1324575)</span></li>
<li>qml/kde/tests/qmlbreadcrumbnavigation/checkableitemproxymodel.cpp <span style="color: grey">(f61485a)</span></li>
<li>qml/kde/tests/qmlbreadcrumbnavigation/kmodelindexproxymapper.cpp <span style="color: grey">(c464938)</span></li>
<li>qml/kde/tests/qmlbreadcrumbnavigation/kproxyitemselectionmodel.cpp <span style="color: grey">(6d176fb)</span></li>
<li>qml/kde/tests/qmlbreadcrumbnavigation/qmllistselectionmodel.cpp <span style="color: grey">(dbc794e)</span></li>
<li>resources/imap/tests/testsubscriptiondialog.cpp <span style="color: grey">(9653b76)</span></li>
<li>resources/kolabproxy/kolabhandler.cpp <span style="color: grey">(0574464)</span></li>
<li>resources/kolabproxy/upgradejob.cpp <span style="color: grey">(74f80fe)</span></li>
<li>resources/maildir/libmaildir/maildir.cpp <span style="color: grey">(9ad4a66)</span></li>
<li>resources/mixedmaildir/kmindexreader/tests/testidxreader.cpp <span style="color: grey">(d51cc9d)</span></li>
<li>resources/mixedmaildir/tests/itemfetchtest.cpp <span style="color: grey">(5372ce5)</span></li>
<li>resources/openxchange/openxchangeresource.cpp <span style="color: grey">(377b908)</span></li>
<li>resources/openxchange/oxa/incidenceutils.cpp <span style="color: grey">(1f0592b)</span></li>
<li>resources/pop3/tests/fakeserver/fakeserver.cpp <span style="color: grey">(2201045)</span></li>
<li>resources/pop3/tests/pop3test.cpp <span style="color: grey">(f6b0f2a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121096/diff/2/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>