<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6416" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks good, just please fix the QString issue and it's good to go.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6416#inline-26862" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">newcertificatewizard.cpp:1460</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                                          <span class="n">ui</span><span class="p">.</span><span class="n">emailLE</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">().</span><span class="n">trimmed</span><span class="p">(),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                                          <span class="bright"></span><span class="n"><span class="bright">ui</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">commentLE</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">text</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">trimmed</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                          <span class="bright"></span><span style="color: #766510"><span class="bright">""</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use <tt style="background: #ebebeb; font-size: 13px;">QString()</tt> or just <tt style="background: #ebebeb; font-size: 13px;">{}</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">""</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R168 Kleopatra</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6416" rel="noreferrer">https://phabricator.kde.org/D6416</a></div></div><br /><div><strong>To: </strong>justusw, aheinecke, KDE PIM: Kleopatra, dvratil<br /><strong>Cc: </strong>dvratil, KDE PIM, dvasin, winterz, vkrause, mlaurent, knauss<br /></div>